Shopify / Shopify/shipit-engine
Potentially use GH's required status checks instead of allow_failures
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 154
- Avg merge
- 2h 26m
- Merged PRs (30d)
- 3
Description
We currently use the ci.allow_failures config in shipit.yml to determine whether or not a commit is deployable. With the introduction of protected branches and status checks (https://github.com/blog/2051-protected-branches-and-required-status-checks) we might be able to get rid of that setting and use whatever is configured on Github.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how ci.allow_failures in shipit.yml determines whether a commit is deployable. Read GitHub's protected branches and required status checks documentation, then identify the deployment decision entry point. Done means establishing whether GitHub's configured required checks can replace ci.allow_failures and documenting or implementing the resulting behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, ruby
- Domain
- ci-cd, devops, release
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100