Shopify / Shopify/shipit-engine
More granular GitHub access restriction.
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 154
- Avg merge
- 2h 26m
- Merged PRs (30d)
- 3
Description
#333 added the possibility to restrict access to the whole shipit instance to a single GitHub team.
Ideally we should improve the granularity, and do access restriction by stack.
As I see it, it should be in the shipit.yml:
teams:
- ACME/developers
- MyOrg/deployers
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading how shipit.yml is parsed and how the whole-instance restriction from #333 is enforced. Trace the access check through stack selection, then define the configuration and behavior needed for separate GitHub teams per stack. Done means the issue's per-stack access restriction is supported and covered by the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, ruby
- Domain
- authorization, devops
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100