Shopify / Shopify/shipit-engine
Command overrides should always be treated as string
Open
Nobody has claimed this yet.
bug
exception
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 154
- Avg merge
- 2h 26m
- Merged PRs (30d)
- 3
Description
deploy:
override:
- true
Will obviously be parsed as true not "true", which breaks shipit.
cc @graemej
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the code that parses deploy command overrides and trace how the YAML value is converted before Shipit uses it. Add a regression test for a boolean-looking override such as true, then verify that the resulting command override remains the string "true".
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100