Shopify / Shopify/shipit-engine
Adding stack from unknown github org should fail
Open
Nobody has claimed this yet.
bug
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 154
- Avg merge
- 2h 26m
- Merged PRs (30d)
- 3
Description
It's possible to add a stack for a github org for which we don't have credentials.
This doesn't actually end up working, and causes Shipit::GithubOrganizationUnknown errors, so it would be better to reject the stack up front, perhaps with a validation that the org is known.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing where stacks accept or validate their GitHub organization and where Shipit::GithubOrganizationUnknown is raised. Confirm the behavior for an unknown organization, then add the upfront rejection and verify that known organizations still work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, ruby
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100