Shopify / Shopify/shipit-engine
Change Shipit::Task::PRESENCE_CHECK_TIMEOUT for each Shipit::Task
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 154
- Avg merge
- 2h 26m
- Merged PRs (30d)
- 3
Description
What is the best way to override the Shipit::Task::PRESENCE_CHECK_TIMEOUT constant on a per-task basis?
I need to adjust the PRESENCE_CHECK_TIMEOUT value for specific Shipit::Task because one type of task is raising an Background job hasn't reported back... error due to a Kubernetes finalizer taking more than 30 seconds (default) to finish.
What is the most effective approach to achieve this without affecting other tasks globally?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Shipit::Task::PRESENCE_CHECK_TIMEOUT and the code that raises the "Background job hasn't reported back..." error. Determine how task-specific configuration could coexist with the 30-second default, then verify that one task can use a longer timeout without changing other tasks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kubernetes, ruby
- Domain
- devops
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100