Shopify / Shopify/shipit-engine
Provide mechanism to override `--dist-tag` in lerna publish
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 154
- Avg merge
- 2h 26m
- Merged PRs (30d)
- 3
Description
https://github.com/Shopify/shipit-engine/blob/f8f47fc797905fcaf5d2a27da7c827c1d3c516ce/lib/snippets/publish-lerna-independent-packages#L33 hard codes the latest tag.
This is problematic for stacks publishing backports to previous versions of a package.
There should be a way to inject a custom value to be passed to --dist-tag.
Something similar exists in https://github.com/Shopify/shipit-engine/blob/f8f47fc797905fcaf5d2a27da7c827c1d3c516ce/app/models/shipit/deploy_spec/npm_discovery.rb#L56-L63 but this too would be insufficient, as a backport stack would need to define an entirely custom tag (e.g. v5-stable or 5.x).
Relevant to https://github.com/Shopify/sewing-kit/pull/2954
cc. @BPScott
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lib/snippets/publish-lerna-independent-packages at the hard-coded latest tag. Compare the related option handling in app/models/shipit/deploy_spec/npm_discovery.rb around lines 56-63. Done means a backport stack can provide a custom value that is passed to --dist-tag, including tags such as v5-stable or 5.x.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js, ruby
- Domain
- release
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100