Shopify / Shopify/shipit-engine
Redeploy buttons are inaccessible when a stack is locked, even in emergency mode.
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 154
- Avg merge
- 2h 26m
- Merged PRs (30d)
- 3
Description
Sometimes, redeploying the latest deploy may be used to fix an issue. This can happen in systems where there is more than one deployment process available, or when/where more direct surgery and deployments may occur.
Simultaneously, we prevent users from deploying changes while a stack is locked. We offer Emergency Mode, which lets users do deploys when there is a lock, and may emit separate hooks when such operations occur.
However, this does not seem to work for Redeploys, which remain disabled even in emergency mode:
You can manually enable the button to proceed, or visit the Deploy controller URL if you are already familiar.
I think we should enable the Redeploy button in emergency mode.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Redeploy button and the Deploy controller URL described in the issue, then trace how locked stacks and Emergency Mode affect the redeploy action. Done means the Redeploy button is available in Emergency Mode for a locked stack and the redeploy operation works without manually enabling the control.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- devops, release
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100