Shopify / Shopify/shipit-engine
Draft PRs are not handled by the merge queue
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 154
- Avg merge
- 2h 26m
- Merged PRs (30d)
- 3
Description
Trying to merge them results in a method not allowed response. We should detect and reject draft PRs explicitly.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in app/models/shipit/pull_request.rb, especially the linked sections around lines 150 and 180-182, and trace how the merge queue handles pull requests. Confirm that draft PRs are explicitly rejected rather than producing a method-not-allowed response, then verify the merge behavior for draft and non-draft PRs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100