Shopify / Shopify/shadowenv

improve behaviour when there's a shadowlisp error

Open
#18 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
458
Forks
22
PR merge metrics
No merged PRs in 30d

Description

Shadowenv should behave better when there's a shadowlisp error:

screen shot 2019-02-21 at 1 27 04 pm

Rather than claiming activation, we should probably suppress the activation message, and maybe even reset the environment to the root/undone state.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the ShadowLisp error shown in the attached screenshot and tracing the activation path that reports success. The issue is done when an error no longer claims activation and the environment is reset to the root or undone state, if that behavior is confirmed.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.