Shopify / Shopify/shadowenv

Handle shadowlisp panics better

Open
#121 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
458
Forks
22
PR merge metrics
No merged PRs in 30d

Description

There are lots of ways to generate a ketos->rust panic, and this shows in the terminal like:

~/s/g/S/shadowenv 𝒎░% cd ~[//areas/core/shopify]
thread 'main' panicked at src/lang.rs:75:69:
called `Result::unwrap()` on an `Err` value: TypeError { expected: "string", found: "unit", value: Some(Unit) }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
//a/c/shopify 𝒎 ≟░%

We should catch these and thoughtfully print them as 1-2 lines shadowenv errors instead.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the terminal panic shown in the issue, then inspect src/lang.rs around line 75 to identify the failing path and how its Result error is surfaced. Trace the ketos-to-Rust boundary and existing shadowenv error output; done means the same invalid input produces a concise 1–2-line shadowenv error instead of a Rust panic.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.