`error_threshold_timeout_enabled` can open too aggressively
Open
@abishanan-shopify is already working on this.
Since Jun 19, 2025.
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 88
- Avg merge
- 3d 19h
- Merged PRs (30d)
- 5
Description
This option was introduced in https://github.com/Shopify/semian/pull/418, which is meant to open on consecutive errors, regardless of time window. However, its implementation does not really take "consecutiveness" into account, causing it to open incorrectly.
For example, with an error_threshold of 2, and error_threshold_timeout_enabled set to false, the following might cause the circuit to open:
error -> success -> success -> success -> success -> ....10000 more successes -> error
This is not the desired behaviour
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.