Shopify / Shopify/semian

Make TestResource#test_acquire_timeout_override work

Open
#329 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
1.5k
Forks
88
Avg merge
3d 19h
Merged PRs (30d)
5

Description

I skipped test TestResource#test_acquire_timeout_override work in https://github.com/Shopify/semian/pull/328

Need to update the code and find how it should work.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the skipped TestResource#test_acquire_timeout_override test referenced in pull request #328, then trace the related implementation in the repository. Determine the intended timeout-override behavior from the existing code and test context. Done means the test is no longer skipped and passes without regressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.