Shopify / Shopify/semian

Audit list of things that can raise ResolveError

Open
#249 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
1.5k
Forks
88
Avg merge
3d 19h
Merged PRs (30d)
5

Description

#230 surfaced a failure that was not marked by Semian to raise a ResolveError.

https://github.com/Shopify/semian/pull/230#pullrequestreview-250070212 suggested grepping to find more of these messages but there's little confidence that it's 100% complete.

We need to come up with a more systematic way of covering these failures.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing issue #230 and the linked pull-request review, then inspect the code paths that raise ResolveError and compare them with the existing Semian failure marking. Use the issue's suggested message search as an initial audit, and consider the work done when the relevant failure paths are systematically identified and covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.