Throw exception when protected resource deligate is nil.
Open
@jpittis is already working on this.
Since Jul 12, 2017.
- Dominant language
- Ruby
- Stars
- 1.5k
- Forks
- 88
- Avg merge
- 3d 19h
- Merged PRs (30d)
- 5
Description
Because we can now disable bulkheads or circuit_breakers for a protected_resource, we should raise an exception trying to access methods of a nil delegate.
For example, with bulkhead: false, resource.count should raise a BulkheadDisabledError rather than a NoMethodError kinda thing.
We should also add something to the docs that recommends using resource.bulkhead.count over resource.count.
cc @sirupsen @csfrancis
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.