Shopify / Shopify/rubydex

Bring URI implementation to Rubydex

Open
#313 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
355
Forks
24
Avg merge
2d 6h
Merged PRs (30d)
17

Description

In the Ruby LSP, we have our own patches to the URI module. There are two main goals with it:

  1. Correct handling of Windows URI <-> file path conversions. Unfortunately, the URI module doesn't handle a few cases and we need to patch the functionality
  2. For the magic comment links we coordinate with Tapioca. These were originally implemented as SoureUri objects, but @paracycle uncovered the much more sophisticated package URL spec that we can use

Let's make sure that Saturn ships with the complete URI objects, so that the LSP, Tapioca and any other project of ours can reuse what we built.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the Ruby LSP URI patches and the linked package URL spec discussion first. Then identify how Saturn should expose complete URI objects for reuse by the LSP and Tapioca; done means those consumers can share the implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby, rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.