Shopify / Shopify/ruby-lsp

Better Rails engine support

Open
#3,647 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug pinned
Dominant language
Ruby
Stars
2k
Forks
281
Avg merge
2h 14m
Merged PRs (30d)
6

Description

We currently don't add the Rails add-on if the workspace structure doesn't include a bin/rails. This means that we sometimes miss Rails engines that don't define this file, which isn't great as they then lose support for running tests through the explorer among other things.

Maybe we can include the add-on on more conditions and do the work to ensure that it won't crash when running in an engine without bin/rails, so that support is improved.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Trace the Rails add-on detection and its test-explorer entry points, then verify that Rails engines without bin/rails receive support and do not crash when tests are run through the explorer.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
testing, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.