Shopify / Shopify/ruby-lsp

Cleanup after test explorer is rolled out

Open
#3,310 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

chore pinned
Dominant language
Ruby
Stars
2k
Forks
281
Avg merge
2h 14m
Merged PRs (30d)
6

Description

After the new test explorer experience is fully rolled out, we have some clean up to do in our code.

  • Clean up old test explorer code. This includes the old handlers and the custom code lens middleware to discover tests
  • Clean up the code lens implementation. It should no longer be responsible for discovering tests, but instead read the cached result from the document instance

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the old test explorer handlers and custom code lens middleware that discover tests. Then inspect how the document instance caches test results; done means removing the obsolete discovery code and having code lens read the cached result instead.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby, vscode
Domain
developer-experience, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.