Shopify / Shopify/ruby-lsp

Provide completion for keyword arguments in method calls

Open
#2,913 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help-wanted pinned server
Dominant language
Ruby
Stars
2k
Forks
281
Avg merge
2h 14m
Merged PRs (30d)
6

Description

If we know exactly which method the user is currently typing, we can provide completion for the keyword arguments required to invoke that method.

E.g.:

class Foo
  def bar(a:, b:)
  end

  def baz
    baz()
      #^^ when the cursor is here we can show `a` and `b` as possible symbol completions
  end
end

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Ruby LSP completion flow for a method call and the logic that identifies the method being typed. Use the example in the issue to determine how required keyword parameters should appear as symbol completions. Done means calls to methods with required keyword arguments offer those argument names without changing unrelated completion behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
developer-experience, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.