Shopify / Shopify/ruby-lsp

Make the extension's test suite less dependent on individual setups

Open
#2,877 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

chore pinned
Dominant language
Ruby
Stars
2k
Forks
281
Avg merge
2h 14m
Merged PRs (30d)
6

Description

Currently, the extension's test suite makes several assumptions about what is going to be available in the user's machine. For example, the Shadowenv test assumes that it will be available and the chruby test assumes rubies will be available in certain locations.

This is not friendly to external contributors who may not have their environments configured similarly to our team. Let's ensure that the test suite skips tests that cannot be executed. Let's also try to ensure that we can run as many tests as possible locally.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the extension test suite and inspect the Shadowenv and chruby tests for assumptions about installed tools and Ruby locations. The work is done when unavailable environments cause those tests to skip while as many tests as possible still run on a contributor's local machine.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.