Shopify / Shopify/ruby-lsp

Support `attr_*` for References

Open
#2,668 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

pinned
Dominant language
Ruby
Stars
2k
Forks
281
Avg merge
2h 14m
Merged PRs (30d)
6

Description

Following up from https://github.com/Shopify/ruby-lsp/pull/2650, we should also support References requests for attr_reader, attr_writer and attr_accessor.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the implementation and tests from pull request #2650, which added References support. Trace how regular reference requests are handled, then identify the coverage needed for attr_reader, attr_writer, and attr_accessor; done means References requests work for all three forms with tests demonstrating the results.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
devtools
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.