Shopify / Shopify/ruby-lsp

VSCode Sticky Scroll no longer works in ERB files after 0.7.10

Open
#2,314 11 comments 0 reactions 1 assignee View on GitHub

@vinistock is already working on this.

Since Jul 16, 2024.

bug pinned
Dominant language
Ruby
Stars
2k
Forks
281
Avg merge
2h 14m
Merged PRs (30d)
6

Description

Description
Reproduction steps
  1. Start Ruby LSP > 0.7.10 using vscode
  2. Open an ERB file
  3. Regression occurs where sticky scroll no longer appears

Example with a YAML file:
On 0.7.10:
image
On 0.7.12:
image

Likely related to the ERB code navigation change in #2235. I am using v0.17.7 of the language server.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.