Shopify / Shopify/ruby-lsp

Handle manually invoked completion

Open
#2,055 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

addons enhancement pinned
Dominant language
Ruby
Stars
2k
Forks
281
Avg merge
2h 14m
Merged PRs (30d)
6

Description

The LSP spec allows users to invoke completion manually without typing anything.

This scenario is very different from what we currently handle because there's no target node. We simply need to show all possible completion items for the current receiver.

We will need to think about how addons can be invoked for this case and how they should enhance the base response. We may need to allow for a nil target intentionally and then define a special event for it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the LSP completionTriggerKind specification and trace the existing completion handling for cases with a target node. Define how manually invoked completion should return all items for the current receiver, how addons participate, and how a nil target or special event is represented. Done means the behavior and addon integration are specified and covered by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.