Shopify / Shopify/ruby-lsp

Explore using Prism's missing nodes to improve on type formatting accuracy

Open
#1,008 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

pinned
Dominant language
Ruby
Stars
2k
Forks
281
Avg merge
2h 14m
Merged PRs (30d)
6

Description

Since YARP Prism can tell us which nodes are missing, we might be able to improve the accuracy of our on type formatting completions if we check which parts of a node are a MissingNode.

Let's explore if this makes the implementation simpler and more robust.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the on-type formatting completion implementation and Prism's MissingNode behavior, both identified in the issue. Determine whether checking missing nodes makes the implementation simpler and more robust; done means a concrete approach and validation plan for improving formatting accuracy.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.