Shopify / Shopify/ruby-lsp-rails

Spring usage

Open
#571 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
688
Forks
44
PR merge metrics
No merged PRs in 30d

Description

  • Current spring activation code hits the Errno::EPERM rescue
  • Spring seems to activate fine without it on MacOS during rails runner so I don't know if the activation code is needed
  • Spring process does stick around after closing the editor and consumes memory. This could be a tradeoff we're happy with for faster boot times later on.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/ruby_lsp/ruby_lsp_rails/runner_client.rb at lines 62-63 and inspect how activation is used during rails runner. Compare the reported macOS behavior with the lingering Spring process; done should establish whether activation is needed and define or document the expected process lifecycle.

Written by the indexing model from the issue text.

Assessment

Tech stack
rails, ruby
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.