Shopify / Shopify/ruby-lsp-rails
Consider testing against multiple Rails versions
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 688
- Forks
- 44
- PR merge metrics
- No merged PRs in 30d
Description
Currently we run CI against the latest release release, and against main, but I'm considering if we should also test against older supported Rails versions, such as 7.2, since there are a number of places where we rely on feature discovery using responds_to?.
This would probably mean having multiple dummy apps in the repo, e.g. test/dummy_rails_8 and test/dummy_rails_7_2.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the current CI configuration and existing dummy app layout, then compare how the latest-release and main Rails jobs are defined. Add coverage for supported older Rails versions such as 7.2, using a separate dummy app if needed, and verify that CI runs the Rails-version coverage successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- ci-cd, testing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100