Shopify / Shopify/roast

Consolidate provider branches in Chat#ruby_llm_context

Open
#887 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
1.2k
Forks
76
PR merge metrics
No merged PRs in 30d

Description

The current case statement on Chat#ruby_llm_context has grown enough to the point where a refactor would be good. We need special cases for some providers that use different configurations (no api base url, extra variables, etc), but we don't need it on the ~80% of providers that use the same variables.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Chat#ruby_llm_context and trace how provider configurations are selected. Identify the shared variables used by most providers and the special cases that must remain distinct; done means the branching is consolidated without changing provider-specific behavior, with the relevant existing tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
ai, backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.