Event listeners are never released
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 91
- Avg merge
- 9d 14h
- Merged PRs (30d)
- 38
Description
SignalRemoteReceiver when detaching nodes is currently only releasing properties but not event listeners.
Attempting to release them causes an issue when re-ordering nodes though, as the repositioned node will keep referencing the released listener.
The corresponding PR that highlights the issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/signals/source/SignalRemoteReceiver.ts at lines 322-324 and review the detach and node-reordering behavior described in PR 559. Determine how listener release interacts with repositioned nodes; done means detached listeners are released without leaving reordered nodes referencing released listeners.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100