Fix issues with `Suspense` when using DOM polyfill
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 91
- Avg merge
- 9d 14h
- Merged PRs (30d)
- 38
Description
While playing with Suspense here: https://github.com/Shopify/remote-dom/compare/add-react-suspense-example?expand=1, I noticed there were issues in both React and Preact. React would not render the suspense fallback at all in the worker (though it does in the iframe), and Preaect would render the fallback, but send an invalid detach command to the host.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked add-react-suspense-example comparison and reproduce the Suspense behavior in the worker and iframe for React, then in the DOM polyfill with Preact. Done means React renders its fallback in the worker and Preact no longer sends an invalid detach command to the host.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100