Shopify / Shopify/remote-dom

Superfluous text node in `root` when using react

Open
#415 1 comment 0 reactions 1 assignee View on GitHub

@lemonmade is already working on this.

Since Aug 16, 2024.

Dominant language
TypeScript
Stars
1.3k
Forks
91
Avg merge
9d 14h
Merged PRs (30d)
38

Description

It appears that when using react, the root always contains a text node, even though you didn't render one

image

to reproduce:

checkout the rd/text-node branch and run pnpm run example:kitchen-sink, open the browser and select react.

You'll see that in addition to the ui-stack, root.children also has an empty text node.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.