Shopify / Shopify/pitchfork

Chore: port integration tests to minitest

Open
#21 0 comments 1 reaction 1 assignee View on GitHub

@paarthmadan is already working on this.

Since Feb 1, 2023.

Dominant language
Ruby
Stars
834
Forks
36
Avg merge
1d 4h
Merged PRs (30d)
7

Description

The current integration tests are inherited from Unicorn. They're very hard to debug, especially if they fail on CI.

It would be good to port them to minitest, with Ruby instead of Bash, it would be much easier to produce readable and actionable error reports.

  • t0000-http-basic
  • t0002-parser-error
  • t0004-heartbeat-timeout
  • t0009-broken-app
  • t0010-reap-logging
  • t0013-rewindable-input-false
  • t0014-rewindable-input-true
  • t0015-configurator-internals
  • t0018-write-on-close
  • t0019-max_header_len
  • t0020-at_exit-handler
  • t0022-listener_names-preload_app
  • t0100-rack-input-tests
  • t0116-client_body_buffer_size
  • t0300-no-default-middleware
  • t2000-promote-worker
  • t9000-preread-input

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.