Shopify / Shopify/packwerk

[Bug Report] Disable sorbet when using spring

Open
#327 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Ruby
Stars
1.9k
Forks
121
Avg merge
2m
Merged PRs (30d)
1

Description

Description
Packwerk does not disable sorbet when using Spring. This slows down checks.

To Reproduce

  • bin/packwerk check says Packwerk couldn't disable Sorbet. Please ensure it isn't being used before Packwerk is loaded.

Expected Behaviour

Sorbet is successfully disabled, but only for packwerk.

bin/rails runner "puts ::T::Private::RuntimeLevels.default_checked_level" should be "always", but packwerk should not print the error.

Screenshots
If applicable, add screenshots to help explain your problem.

Version Information

  • Packwerk: 3.0
  • Ruby 3.2.1

Additional Context

https://github.com/Shopify/packwerk/pull/326

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running bin/packwerk check with Spring enabled and compare it with bin/rails runner "puts ::T::Private::RuntimeLevels.default_checked_level". Trace the Packwerk entry point and its Sorbet-disabling behavior; done means Packwerk no longer prints the error while the Rails runner still reports always.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
cli, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.