Shopify / Shopify/mruby-engine
mgem questions
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 81
- Forks
- 19
- Avg merge
- 12d 4h
- Merged PRs (30d)
- 1
Description
First of all, amazing project!
Now some questions:
-
Any chance to move the mruby-mpdecimal into an own repository so that we can link it from our mgem-list (http://github.com/mruby/mgem-list)?
-
I notice that you removed several methods from the mruby-time gem (e.g. local, now). I guess it is relevant from your security point of view, I would like to understand your thought about this change.
Furthermore thanks for your great contribution from this bug bounty. I guess it is somehow financed by Spotify. Nevertheless I think the security considerations are a really valuable addition. So thanks again!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the mruby-mpdecimal project and the mruby-time changes referenced in the issue, then check the mruby/mgem-list repository context. A complete response would explain the removed methods and security rationale and establish whether mruby-mpdecimal should move to its own repository.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- security
- Issue type
- Documentation
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 15/100