Shopify / Shopify/money

Currency database should know if a currency is still in use

Open
#77 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
361
Forks
50
PR merge metrics
No merged PRs in 30d

Description

For example 'NLG' is the ISO4217 code for the Dutch guilder that got replaced by the Euro in 2002. The euro was introduced as legal tender in 1999.

Use case: generating a list of valid and currently in use ISO codes to show in a dropdown for the user to select, while having a database validation on all valid currency codes.

The Unicode CLDR has this data:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the repository's currency database implementation and the referenced CLDR currencyData.json, then compare it with the ISO 4217 table. Define how valid codes remain available for validation while currently used codes can be selected, and verify that both cases are represented in the resulting database behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.