money_column currency option
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 361
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Description
For the next major release we should look into changing money_column to support a single currency. Rather than both currency and currency_column, we could have only currency and make it accept something responding to call or to_s.
Example:
class Product
money_column :price, currency: ->(product) { product.currency }
money_column :price_usd, currency: 'USD'
end
I think this is easier to reason about and will help clean up the code
cc: @bdewater
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named; start by locating the current money_column implementation and its handling of currency and currency_column. Done would mean deciding and implementing one currency option that accepts either a fixed value or a callable value, with the existing behavior and release migration addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- fintech-quant
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100