| json filter not escaping properly with mix of angle quotes and regular quotes
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 11.9k
- Forks
- 1.5k
- Avg merge
- 17h 55m
- Merged PRs (30d)
- 3
Description
Hi there,
I've found a bug with the liquid | json
filter not escaping properly if a product description has a mix of regular quote marks (this guy: ' ) and angle quote marks (this guy: ’)
I put together a screencast explaning how to reproduce this and how to make a temporary fix: https://youtu.be/yjO3m-kMdZU
Thanks
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by reproducing the Liquid | json filter case described in the issue with both regular and angle quote marks, using the linked screencast as context; done means the mixed quotes are escaped correctly without relying on the temporary fix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100