Shopify / Shopify/liquid

Add support for cycling through arrays

Open
#951 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

At the moment cycle cycles through a "group of strings" (whatever kind of datatype that is ^^),
but I would actually expect it to cycle through an array.

That would also make following construct possible:

{% assign numbers = (1..50) %}

{% cycle numbers %}
{% cycle numbers %}
{% cycle numbers %}
…

Can we add support for this?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the cycle tag implementation and the code handling its current group-of-strings input. Use the numbers array example in the issue to verify repeated calls cycle through array elements and confirm the existing behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.