Shopify / Shopify/liquid

Cannot re-assign variable inside snippet

Open
#911 1 comment 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

In template:

{% include 'my-snippet', test_variable: 'foo' %}

my-snippet.liquid

{%- assign test_variable = 'bar' -%}
{{ test_variable }}

Results in foo instead of bar.

However, everything works as expected when including the snippet like this:

{%- assign test_variable = 'foo' -%}
{% include 'my-snippet' %}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the two Liquid snippets shown in the issue, comparing an include with an argument against an include using a prior assignment. Trace the include and assignment scoping entry points and existing tests; done means the reported behavior is either corrected or covered by an explicit, verified scoping rule.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.