Shopify / Shopify/liquid

Error message doesn't identify location of error

Open
#904 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

I have a web site built with Jekyll using Liquid and a recent upgrade from Liquid 3.0.6 to 4.0.0 throws the following error:

Liquid Exception: no implicit conversion of Fixnum into String in /_layouts/default.html

The error doesn't specify the line number which makes it very hard to fix the issue, especially considering that this is a layout file that does a number of includes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the error reported for /_layouts/default.html and its included layouts, then trace how Liquid 4.0.0 reports template exceptions compared with Liquid 3.0.6. Done means the exception identifies the relevant line number so errors in layouts with multiple includes can be located.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.