Shopify / Shopify/liquid

Theme SCSS compilation throws error

Open
#868 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

I am getting syntax error on saving theme.scss.liquid file. Following are error details:

Line 118 — Liquid syntax error: Variable '{{ '#{$image}' was not properly terminated with regexp: /\}\}/

Mixin:

@mixin background-image($image) {
  background-image: url('{{ "#{$image}" | asset_url }}');
}

Usage:

.foo {
  @include background-image('foo.png');
}

Can anyone help me out what is missing over here?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported syntax error while saving the supplied theme.scss.liquid mixin and usage. Trace how the Liquid parser handles the nested SCSS interpolation; done means the example no longer produces the reported unterminated-variable error or the expected limitation is clearly documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
scss
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.