Possible bug with assign precedence in included partials

Given a template that includes another template like so:

{% include 'item' %}

If you then assign a value to the "magic" variable of the template name, a reasonable expectation here would be for the new value to replace the other value.

{% assign item = 'foo' %}
{{ item }}

However, the assign tag in its render method does:

    def render(context)
      val = @from.render(context)
      context.scopes.last[@to] = val
      context.resource_limits.assign_score += assign_score_of(val)
      ''.freeze
    end

And the context.scopes.last means that it has less variable lookup precedence than the template variable and thus will always, in the case of this example be nil.

It seems to me that it should allocate to context.scopes.first as the current active scope? Is this a bug or is there some other logic going on here?

Cheers!

Start with the assign tag's render method shown in the issue, then inspect how context.scopes are populated and resolved for included templates. Reproduce the assign/include example and determine the intended precedence; done means the behavior is settled and covered by a regression test.