Shopify / Shopify/liquid

Unclosed {% if %} statements return validation errors when they are wrapped in the {% comment %} tag.

Open
#801 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

For example the following will not validate:

{% comment %}{% if foo == "bar" %}{% endcomment %}
  baz
{% comment %}{% endif %}{% endcomment %}

=> Liquid::SyntaxError: Liquid syntax error (line 1): Unknown tag 'endcomment'

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the supplied template and tracing validation of the {% comment %} and {% if %} tags. Inspect the parser or tag-validation entry point involved in the Unknown tag 'endcomment' error; done means this example validates without that error while preserving comment behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.