Shopify / Shopify/liquid

else block in case always executes if it's the first block

Open
#796 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

In case if the else block is the very first, it always executes.

{% assign num = 1 %}
{% case num %}
{% else %}
else
{% when 1 %}
1
{% endcase %}

This outputs else but I would expect this to output 1. If you change the order to this:

{% assign num = 1 %}
{% case num %}
{% when 1 %}
1
{% else %}
else
{% endcase %}

It outputs 1 correctly.

In case.rb it sets execute_else_block to true in the beginning. It should probably go through all the when blocks first, and if none apply, then it should execute the else block if it exists.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in case.rb and reproduce the issue with the two case examples from the report. Check that a matching when branch wins even when else appears first, while else runs only when no when branch matches.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.