Shopify / Shopify/liquid

How do we correlate Liquid::Error with input template on parsing time?

Open
#708 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

Problem:

When error occurs on rendering time then line_number and template_name are mostly accessible for Liquid::Error object (see #574) when possible.

But when error occurs on parsing time (eg SyntaxError) then only (correct) line_number of included template is present. So it is hard to track down where in included templates the error occurs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the behavior described in #574, then trace how parsing errors from included templates become Liquid::Error objects. The change is complete when parsing-time errors preserve both the included template's line_number and its template_name, making the source template identifiable.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.