Shopify / Shopify/liquid

[Request] Number formatting filter

Open
#567 12 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature Request
Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

I was surprised that there isn't a number format filter similar to the date format. I am new to both Ruby and Liquid, but looking through the code it looks like this would not be difficult to add. I plan to give it a try, but with my current schedule I don't know when I can sit down and poke around with it.

I figured I would post here and see if anyone else was missing this and wanted to build it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no file or test. Start by locating the existing date format filter and how filters are registered, then review any related tests. The expected number-format behavior still needs to be defined; done should include an available filter with verified output.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.