Shopify / Shopify/liquid

Start using keyword arguments

Open
#544 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature Request
Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

If/when we are releasing a new major version, we should try to use keyword args.
this is really awful right now: https://github.com/Shopify/liquid/blob/master/lib/liquid/context.rb#L19

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading lib/liquid/context.rb at line 19 and inspect how its arguments are used. Determine the scope of adopting keyword arguments for a future major release; done would require an agreed migration plan and updated affected interfaces.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.