Shopify / Shopify/liquid

Invalid filters are ignored without warning

Open
#422 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Report Feature Request
Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

Using a filter that Liquid does not recognize causes the invalid filter to be ignored and no warning will be generated.

It would be nice if there was a way to get a warning in this case, instead of these errors being silently ignored. I was expected the strict error mode to catch invalid filters upon parse, and I think that would be the ideal solution.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing a template that uses an unrecognized filter, then trace how strict error mode handles parsing and unknown filters. Done means invalid filters no longer pass silently and the chosen warning or parse-time error is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.