Shopify / Shopify/liquid

Jekyll+Liquid continuous integration

Open
#394 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature Request
Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

We often accidentally break Jekyll things by doing things in Liquid.

Once Jekyll is on Liquid 3, we should set up a CI system that runs Jekyll tests against the current Liquid master and somehow notifies us that we just broke Jekyll.

Not sure how exactly, but I would like to not do that on each Travis run in Liquid (because the Jekyll test suite is fucking slow as hell, and I also don't want every Liquid change that accidentally breaks Jekyll make the Liquid tests fail, maybe the fix for a particular break is in Jekyll and not in Liquid).

Thoughts @arthurnn, @parkr?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the repository's existing Travis CI configuration and the Jekyll test suite referenced in the issue. Determine how to run those tests against Liquid master without coupling them to every Liquid test run, and consider the work done when failures notify maintainers separately.

Written by the indexing model from the issue text.

Assessment

Tech stack
jekyll, ruby
Domain
ci-cd
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.