Shopify / Shopify/liquid

Liquid doesn't cope with quoted liquid tag identifiers.

Open
#344 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Report Parser
Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

Example Liquid code:
test: {{ 'blah {{ yy }}' | replace: '{{', 'xx' }}
Expected output:
test: blah xx yy }}
Actual output:
test: ' | replace: ',

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the quoted Liquid example from the issue and trace how the parser handles the nested {{ yy }} and replace arguments. The work is done when the example produces test: blah xx yy }} and regression coverage verifies that quoted Liquid tag identifiers are parsed correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.