overly strict parsing rejects valid code
Open
Nobody has claimed this yet.
Bug Report
Parser
- Dominant language
- Ruby
- Stars
- 11.9k
- Forks
- 1.5k
- Avg merge
- 17h 55m
- Merged PRs (30d)
- 3
Description
{{ variable | remove '}' }}
the '}' is considered as an invalid closing tag. this also applies inside tags (e.g. {% assign variable = '}' %} will fail)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the two parsing examples in the issue and trace the parser entry point that rejects the closing brace. Confirm that a } inside quoted filter or tag values is accepted without changing tag termination, then add regression coverage for both examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100