Shopify / Shopify/liquid

`product.images` missing variant data beyond 250th variant

Open
#1,986 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

image.attached_to_variant? returns false and image.variants is empty if the image is attached to a variant that is not in the first 250 variants.

image_attached_to_250th_variant.attached_to_variant? # true
image_attached_to_251st_variant.attached_to_variant? # false

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported behavior with images attached to the 250th and 251st variants, then trace the implementation of image.variants and attached_to_variant?. Done means both methods return the correct association for variants beyond the first 250, with coverage for the boundary shown in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.